-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal(hybrid): Add Replay Mask options to dict init #4492
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cc31630 | 1232.28 ms | 1253.73 ms | 21.45 ms |
f576153 | 1217.17 ms | 1225.06 ms | 7.89 ms |
b9a9dca | 1377.00 ms | 1382.55 ms | 5.55 ms |
18d491a | 1226.86 ms | 1251.35 ms | 24.49 ms |
2e88e64 | 1233.64 ms | 1241.53 ms | 7.89 ms |
f8833c4 | 1230.00 ms | 1245.27 ms | 15.27 ms |
69d2789 | 1224.14 ms | 1247.17 ms | 23.02 ms |
da5462e | 1198.18 ms | 1229.14 ms | 30.96 ms |
dc0db9e | 1222.10 ms | 1240.90 ms | 18.80 ms |
ab6fee4 | 1227.63 ms | 1239.80 ms | 12.17 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
cc31630 | 21.58 KiB | 694.57 KiB | 672.99 KiB |
f576153 | 20.76 KiB | 425.77 KiB | 405.01 KiB |
b9a9dca | 21.58 KiB | 414.59 KiB | 393.01 KiB |
18d491a | 21.58 KiB | 544.86 KiB | 523.28 KiB |
2e88e64 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
f8833c4 | 21.58 KiB | 422.66 KiB | 401.08 KiB |
69d2789 | 21.58 KiB | 548.09 KiB | 526.50 KiB |
da5462e | 22.85 KiB | 412.98 KiB | 390.13 KiB |
dc0db9e | 20.76 KiB | 419.62 KiB | 398.86 KiB |
ab6fee4 | 22.84 KiB | 401.67 KiB | 378.83 KiB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4492 +/- ##
=============================================
- Coverage 91.429% 91.414% -0.016%
=============================================
Files 616 615 -1
Lines 68657 68640 -17
Branches 24627 24522 -105
=============================================
- Hits 62773 62747 -26
- Misses 5792 5801 +9
Partials 92 92
... and 33 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This reverts commit 4595cdd.
📜 Description
This PR add mask class and unmask class to replay options for hybrid SDKs.
💡 Motivation and Context
RN uses Sentry init with dict, at the moment it's not possible to set these options thru the dict.
💚 How did you test it?
ci, unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps