Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal(hybrid): Add Replay Mask options to dict init #4492

Merged
merged 7 commits into from
Oct 31, 2024

Conversation

krystofwoldrich
Copy link
Member

📜 Description

This PR add mask class and unmask class to replay options for hybrid SDKs.

💡 Motivation and Context

RN uses Sentry init with dict, at the moment it's not possible to set these options thru the dict.

💚 How did you test it?

ci, unit tests

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Oct 31, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.14 ms 1233.12 ms 8.98 ms
Size 21.90 KiB 725.67 KiB 703.76 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
cc31630 1232.28 ms 1253.73 ms 21.45 ms
f576153 1217.17 ms 1225.06 ms 7.89 ms
b9a9dca 1377.00 ms 1382.55 ms 5.55 ms
18d491a 1226.86 ms 1251.35 ms 24.49 ms
2e88e64 1233.64 ms 1241.53 ms 7.89 ms
f8833c4 1230.00 ms 1245.27 ms 15.27 ms
69d2789 1224.14 ms 1247.17 ms 23.02 ms
da5462e 1198.18 ms 1229.14 ms 30.96 ms
dc0db9e 1222.10 ms 1240.90 ms 18.80 ms
ab6fee4 1227.63 ms 1239.80 ms 12.17 ms

App size

Revision Plain With Sentry Diff
cc31630 21.58 KiB 694.57 KiB 672.99 KiB
f576153 20.76 KiB 425.77 KiB 405.01 KiB
b9a9dca 21.58 KiB 414.59 KiB 393.01 KiB
18d491a 21.58 KiB 544.86 KiB 523.28 KiB
2e88e64 22.85 KiB 408.88 KiB 386.03 KiB
f8833c4 21.58 KiB 422.66 KiB 401.08 KiB
69d2789 21.58 KiB 548.09 KiB 526.50 KiB
da5462e 22.85 KiB 412.98 KiB 390.13 KiB
dc0db9e 20.76 KiB 419.62 KiB 398.86 KiB
ab6fee4 22.84 KiB 401.67 KiB 378.83 KiB

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.414%. Comparing base (e92acb3) to head (9c7aaa7).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4492       +/-   ##
=============================================
- Coverage   91.429%   91.414%   -0.016%     
=============================================
  Files          616       615        -1     
  Lines        68657     68640       -17     
  Branches     24627     24522      -105     
=============================================
- Hits         62773     62747       -26     
- Misses        5792      5801        +9     
  Partials        92        92               
Files with missing lines Coverage Δ
...tegrations/SessionReplay/SentryReplayOptions.swift 92.682% <100.000%> (+1.254%) ⬆️
...tions/SessionReplay/SentryReplayOptionsTests.swift 100.000% <100.000%> (ø)

... and 33 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e92acb3...9c7aaa7. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Brewfile.lock.json Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@krystofwoldrich krystofwoldrich merged commit 7cddee1 into main Oct 31, 2024
62 of 64 checks passed
@krystofwoldrich krystofwoldrich deleted the kw/replay/dict-masking branch October 31, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants