Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(user feedback): move objc sources to correct location #4490

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

armcknight
Copy link
Member

As promised regarding #4364 (comment), move the sources to the correct location. Also taking this opportunity to rename the classes per #4364 (comment)

for #4270

#skip-changelog

@armcknight armcknight changed the title ref: move integration objc sources to correct location ref(user feedback): move objc sources to correct location Oct 30, 2024
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.56 ms 1255.98 ms 18.42 ms
Size 21.90 KiB 724.10 KiB 702.20 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e84bc3f 1196.62 ms 1218.86 ms 22.24 ms
cc31630 1235.22 ms 1252.51 ms 17.29 ms
f576153 1210.02 ms 1228.94 ms 18.92 ms
becc941 1221.90 ms 1240.37 ms 18.47 ms
3cd0156 1216.37 ms 1232.84 ms 16.47 ms
18d491a 1229.78 ms 1252.67 ms 22.90 ms
f8833c4 1229.69 ms 1236.45 ms 6.76 ms
69d2789 1235.73 ms 1254.00 ms 18.27 ms
070db34 1228.64 ms 1240.24 ms 11.61 ms
3a31fc9 1237.35 ms 1249.02 ms 11.67 ms

App size

Revision Plain With Sentry Diff
e84bc3f 20.76 KiB 434.72 KiB 413.96 KiB
cc31630 21.58 KiB 694.58 KiB 672.99 KiB
f576153 20.76 KiB 425.77 KiB 405.01 KiB
becc941 21.58 KiB 419.82 KiB 398.24 KiB
3cd0156 21.58 KiB 706.47 KiB 684.89 KiB
18d491a 21.58 KiB 544.87 KiB 523.29 KiB
f8833c4 21.58 KiB 422.66 KiB 401.08 KiB
69d2789 21.58 KiB 548.09 KiB 526.51 KiB
070db34 21.58 KiB 574.17 KiB 552.59 KiB
3a31fc9 20.76 KiB 414.45 KiB 393.69 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@armcknight armcknight merged commit ed470cf into main Oct 31, 2024
60 of 62 checks passed
@armcknight armcknight deleted the armcknight/feat(user-feedback)/refactor-sources branch October 31, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants