-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Capture all touches with session replay #4477
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4477 +/- ##
=============================================
- Coverage 91.807% 91.791% -0.017%
=============================================
Files 610 609 -1
Lines 68233 68123 -110
Branches 24494 24334 -160
=============================================
- Hits 62643 62531 -112
- Misses 5496 5500 +4
+ Partials 94 92 -2
... and 37 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
643853e | 1225.75 ms | 1247.00 ms | 21.25 ms |
b15521e | 1231.82 ms | 1252.23 ms | 20.41 ms |
5be7a7c | 1223.25 ms | 1237.12 ms | 13.87 ms |
6ccaa36 | 1240.39 ms | 1254.80 ms | 14.41 ms |
bfe863d | 1223.19 ms | 1236.23 ms | 13.04 ms |
3297d6e | 1219.02 ms | 1243.25 ms | 24.23 ms |
addcf42 | 1249.22 ms | 1269.82 ms | 20.60 ms |
2384e6d | 1225.90 ms | 1245.47 ms | 19.57 ms |
ff5c1d8 | 1236.67 ms | 1252.34 ms | 15.67 ms |
8526e93 | 1228.24 ms | 1239.14 ms | 10.90 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
643853e | 21.58 KiB | 655.73 KiB | 634.15 KiB |
b15521e | 21.58 KiB | 573.18 KiB | 551.59 KiB |
5be7a7c | 21.58 KiB | 671.89 KiB | 650.31 KiB |
6ccaa36 | 21.58 KiB | 714.45 KiB | 692.87 KiB |
bfe863d | 21.58 KiB | 414.57 KiB | 392.99 KiB |
3297d6e | 21.58 KiB | 418.45 KiB | 396.86 KiB |
addcf42 | 22.85 KiB | 413.42 KiB | 390.57 KiB |
2384e6d | 21.58 KiB | 572.21 KiB | 550.63 KiB |
ff5c1d8 | 20.76 KiB | 430.98 KiB | 410.22 KiB |
8526e93 | 20.76 KiB | 420.22 KiB | 399.47 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Some touches may happening in between segments and were not sent to Sentry.
💡 Motivation and Context
Fixes https://github.com/getsentry/team-replay/issues/466
💚 How did you test it?
Unit test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps