Refactor import paths and support python packages as sources #22
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We decided to package jsonnet libraries as static resources in
jsonnet packages.
The recommended way in python >3.10 to load statics resources is via
importlib.resources.files()
. This PR introduce an abstarction aroundit to wire it up in the jsonnet module.
The issue with
importlib.resources
is that it does not necessarilyresturns
Path
objects. It returnsTraversable
objects, so we needto bridge the gap. Thus the abstraction.
Also refactored the callback method into their own module that made
thinks easier and more testable.
Also added tests.