Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dev:oidc npm script #1037

Closed

Conversation

alxndrsn
Copy link
Contributor

  • generate public/client-config.js at foreman startup
  • remove nginx's special handling for client-config.js

Closes #1034

* generate public/client-config.js at foreman startup
* remove nginx's special handling for client-config.js

Closes getodk#1034
@matthew-white
Copy link
Member

matthew-white commented Oct 15, 2024

I'm interested in what you think of #1038, but this approach also looks reasonable to me. It'd be nice to remove the addition of Docker in the Procfile though, since that's being discussed at #1035.

remove nginx's special handling for client-config.js

We have special logic around this file in prod as well, so my feeling is that it's OK to have some special handling in this local nginx config. But I also don't have any attachment to it: I'd be OK generating client-config.json locally, as this PR does, if you think that's the best approach.

@alxndrsn
Copy link
Contributor Author

#1034 not recreatable, so this change is not required.

@alxndrsn alxndrsn closed this Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm run dev:oidc broken
2 participants