Disallow entity creation via API for unpublished datasets #986
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#483
Follows suggestions from that PR:
Datasets.get()
was getting all datasets including unpublished ones so entities could in some cases be created via API before dataset was published and available (only if they had no data properties, though).Datasets.get()
throughout codepublishedOnly
non-optional and set to false in the only place it matters: when uploading multiple forms that contribute to a dataset and none are published yet.What has been done to verify that this works as intended?
Test and inspecting and agreeing with the comments in the original issue.
Why is this the best possible solution? Were any other approaches considered?
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Can't make entities before their entity lists.
Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.
no
Before submitting this PR, please make sure you have:
make test-full
and confirmed all checks still pass OR confirm CircleCI build passes