Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle offline entities with baseVersion and trunkVersion #1154

Merged
merged 13 commits into from
Jun 24, 2024

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Jun 11, 2024

Possible backend solution for getodk/central#669

XML form that allows branch id / base version / trunk version to be set.

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.yaml as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interactive review

lib/model/query/entities.js Outdated Show resolved Hide resolved
lib/model/migrations/20240607-02-add-submission-backlog.js Outdated Show resolved Hide resolved
lib/model/migrations/20240607-02-add-submission-backlog.js Outdated Show resolved Hide resolved
lib/worker/jobs.js Show resolved Hide resolved
lib/model/query/entities.js Show resolved Hide resolved
lib/model/query/entities.js Show resolved Hide resolved
@ktuite ktuite marked this pull request as ready for review June 21, 2024 22:22
Copy link
Member Author

@ktuite ktuite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interactive review

lib/data/entity.js Outdated Show resolved Hide resolved
lib/data/entity.js Outdated Show resolved Hide resolved
lib/model/migrations/20240607-02-add-submission-backlog.js Outdated Show resolved Hide resolved
lib/model/query/entities.js Outdated Show resolved Hide resolved
lib/model/query/entities.js Outdated Show resolved Hide resolved
test/integration/api/offline-entities.js Show resolved Hide resolved
test/integration/api/offline-entities.js Show resolved Hide resolved
test/integration/api/offline-entities.js Outdated Show resolved Hide resolved
test/integration/api/offline-entities.js Show resolved Hide resolved
test/integration/api/offline-entities.js Outdated Show resolved Hide resolved
@ktuite ktuite merged commit cc0ac3d into master Jun 24, 2024
5 checks passed
@ktuite ktuite deleted the ktuite/offline_entities branch June 24, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants