Exclude deleted entities from extended metadata about entity list #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR relates to getodk/central#560 and I think is a major part of the issue there. It looks like we weren't excluding deleted entities from extended metadata about the entity list.
You can see this by looking at the example in the issue: https://staging.getodk.cloud/#/projects/62/entity-lists/trees/entities. There, the count of entities is sometimes off by 1. And there is 1 deleted entity: https://staging.getodk.cloud/v1/projects/62/datasets/trees/entities?deleted=true
What has been done to verify that this works as intended?
New test.
Before submitting this PR, please make sure you have:
make test-fulland confirmed all checks still pass OR confirm CircleCI build passes