Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count of pending submissions involving edits #1058

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Dec 7, 2023

Closes getodk/central#561

Submission edits were getting counted/including in pending submissions because their specific submissionDef didn't create any entity defs. I modified the pending submission query to look for any existing entity def with the same submission, not just the same submission def.

What has been done to verify that this works as intended?

Tests

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.

no

Before submitting this PR, please make sure you have:

  • run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite merged commit 38410eb into master Dec 8, 2023
5 checks passed
@ktuite ktuite deleted the ktuite/pending_subs branch December 8, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Count of pending submissions includes edits that it shouldn't
2 participants