Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for entity-updating forms modifying dataset properties #1034

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Oct 27, 2023

Closes getodk/central#516

Forms that update entities vs. creating entities don't get parsed any differently at upload time. The effects these forms have on dataset properties are the same as entity-creation forms. This PR adds a few tests of this behavior.

I think these tests will be more important to have in place when we get back to this issue: getodk/central#518 (Restrict submissions to the entity actions listed in the form) because that will involve code changes around dataset parsing and form uploading.

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

test/integration/api/datasets.js Outdated Show resolved Hide resolved
test/integration/api/datasets.js Outdated Show resolved Hide resolved
@ktuite ktuite merged commit 048a5b9 into master Oct 31, 2023
5 checks passed
@ktuite ktuite deleted the ktuite/update_form_tests branch October 31, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow form that just updates entities to modify entity list
2 participants