Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable host setup loading via ENV variable #78

Merged
merged 1 commit into from
May 12, 2024
Merged

Conversation

bastianallgeier
Copy link
Member

You can now load a different host config by setting the new KIRBY_HOST env variable:

env KIRBY_HOST=production.com kirby my-command

@lukasbestle could you have a look at this. I tried to also implement the idea of an additional --env or --host option, but we need to load Kirby first before we can really start parsing the arguments and it would have turned into a bad hack.

I found HOST to be better than ENV, but I wonder if we should do KIRBY_CLI_HOST instead? Not entirely sure.

@bastianallgeier bastianallgeier linked an issue May 3, 2024 that may be closed by this pull request
@bastianallgeier bastianallgeier added this to the 1.5.0 milestone May 3, 2024
@lukasbestle
Copy link
Member

lukasbestle commented May 5, 2024

I like KIRBY_HOST. Don't think we need KIRBY_CLI_HOST as it's obvious we are running the CLI and the command is just called kirby.

Implementation looks good as well. 👍

@bastianallgeier bastianallgeier merged commit ef838d6 into develop May 12, 2024
10 checks passed
@bastianallgeier bastianallgeier deleted the feature/host branch May 12, 2024 09:14
@bastianallgeier bastianallgeier mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow usage of environments
3 participants