-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change runtime to bun #405
Conversation
Are the changes to the installation guide (or the part usage without installation) in the |
I was not able to get the module resolution working with I also struggle validating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only learnt of bun at the codesprint, so I've no useful opinion on switching from one to the other. However, if it addresses #393 then I am all for it!
You also might want to rephrase your commit messages so that the support for openlayers does not appear in the changelog |
BREAKING CHANGE: changes runtime from node to bun
lyrx can only be written
f586c8e
to
146338c
Compare
I am +0 on the change of the runtime, so not blocking. I really would like to stress that installation via |
After this change, |
Isn't this a change more radical than it needs to be? Using bun to create the standalone binaries is fine. But what's the benefit of getting rid of a build that works with node? I just created #407, by creating a single javascript file that runs fine everywhere, using rollup. There's no need to get rid of node support, while still being able to use bun. |
This is superseeded by #407. I'll create a new PR with the changes that are still useful later. |
This changes the runtime and creation of the binaries from node to bun.
It also adds options to read ArcGIS styles via geostyler-lyrx-parser.