Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename the client application to geostyler from geostyler-cli #388

Closed
wants to merge 1 commit into from
Closed

fix: rename the client application to geostyler from geostyler-cli #388

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-binaries.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
try {
for (const fileName of fileNames) {
const filePath = folderPath + fileName;
const renamedFilePath = folderPath + fileName.replace('-win', '').replace('-macos', '').replace('-linux', '');
const renamedFilePath = folderPath + fileName.replace('-cli-win', '').replace('-cli-macos', '').replace('-cli-linux', '');

Check warning on line 28 in package-binaries.js

View workflow job for this annotation

GitHub Actions / build (18.x) 

This line has a length of 128. Maximum allowed is 120

Check warning on line 28 in package-binaries.js

View workflow job for this annotation

GitHub Actions / build (20.x) 

This line has a length of 128. Maximum allowed is 120
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const renamedFilePath = folderPath + fileName.replace('-cli-win', '').replace('-cli-macos', '').replace('-cli-linux', '');
const renamedFilePath = folderPath + fileName
.replace('-cli-win', '')
.replace('-cli-macos', '')
.replace('-cli-linux', '');

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KaiVolland - in the end we are keeping geostyler-cli and removing geostyler! See #394


// Rename the file
await renameFile(filePath, renamedFilePath);
Expand Down
Loading