Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/drop support for php 7. Modernizations #322

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Chris53897
Copy link

@Chris53897 Chris53897 commented May 9, 2022

I am aware that most users are still on 7.4.
But i guess (hope) version 6 of this bundle is useing php >= 8.

There are BC breaks because of the typehints. That is the reason i suggest version 6 for this PR.

  • drop-support-for-php-7
  • add php8 feature
  • add strong php 8 typehints
  • remove MapzenFactory and GeoIPsFactory
  • migrate phpunit.xml.dist to phununit 9 format
  • fixed some spelling mistake

WDYT?

P.S: If someone has a solution for phpstan-warning, please let me know.

@norkunas
Copy link
Member

norkunas commented May 9, 2022

Sorry, but it's too hard to review so many changes in a single PR, so I'd prefer splitting features.
And since we need to align with Symfony maintained versions, we won't currently change php requirements

@Chris53897
Copy link
Author

That is understandable.

Most features depend on php 8. Others could be split now, or after dropping the support of php 7.
I will split some tasks.

Are there any plans for version 6?
With 5.x php 7.3 ist still supported to align with symfony.
But i can understand the maintenance overhead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants