Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-misc/kio-admin: new package, add 9999 #998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

kde-misc/kio-admin: new package, add 9999 #998

wants to merge 1 commit into from

Conversation

parona-source
Copy link
Contributor

No description provided.

a17r
a17r requested changes Aug 11, 2024
View reviewed changes
Copy link
Member

@a17r a17r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Which kde*-meta package would it best fit into?

kde-misc/kio-admin/kio-admin-9999.ebuild Outdated Show resolved Hide resolved
kde-misc/kio-admin/kio-admin-9999.ebuild Outdated Show resolved Hide resolved
kde-misc/kio-admin/kio-admin-9999.ebuild Outdated Show resolved Hide resolved
kde-misc/kio-admin/kio-admin-9999.ebuild Outdated
SLOT="6"

DEPEND="
>=dev-qt/qtbase-${QTMIN}:6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for any USEdeps here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://invent.kde.org/search?search=find_package(Qt&nav_source=navbar&project_id=11819&group_id=1561&search_code=true&repository_ref=master

Only Core searched for by find_package. I dont see it linking explicitly to any Qt library.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see linking to Qt6DBus as well as Qt6Gui.

kde-misc/kio-admin/kio-admin-9999.ebuild Outdated Show resolved Hide resolved
@parona-source
Copy link
Contributor Author

parona-source commented Aug 11, 2024 •
edited
Loading

For what I can see kde-misc has been used for all the KIO workers. Only exceptions are dev-util/kio-perldoc and net-misc/kio-zeroconf

@a17r
Copy link
Member

a17r commented Aug 11, 2024 •
edited
Loading

For what I can see kde-misc has been used for all the KIO workers. Only exceptions are dev-util/kio-perldoc and net-misc/kio-zeroconf

yes, kde-*/ categories are deprecated, but I was more asking about your thoughts on where to reference it from kde-apps/kde*-meta. Traditionally all KDE Gear packages are being pulled in by some meta package. Captain obvious would probably choose kdeadmin-meta

@parona-source
Copy link
Contributor Author

kdeadmin-meta does seem the most reasonable.

a17r
a17r requested changes Aug 11, 2024
View reviewed changes
kde-misc/kio-admin/kio-admin-9999.ebuild Outdated
SLOT="6"

DEPEND="
>=dev-qt/qtbase-${QTMIN}:6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see linking to Qt6DBus as well as Qt6Gui.

a17r
a17r requested changes Aug 11, 2024
View reviewed changes
kde-misc/kio-admin/kio-admin-9999.ebuild Outdated Show resolved Hide resolved
@parona-source parona-source force-pushed the kio-admin branch 2 times, most recently from abb3f83 to 6e406b5 Compare August 12, 2024 15:38
a17r
a17r requested changes Aug 12, 2024
View reviewed changes
app-admin/kio-admin/metadata.xml Outdated
<name>Gentoo KDE Project</name>
</maintainer>
<upstream>
<bugs-to>https://bugs.kde.org/</bugs-to>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<bugs-to>https://bugs.kde.org/</bugs-to>
<bugs-to>https://bugs.kde.org/enter_bug.cgi?product=kio-admin</bugs-to>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you intend that other packages in tree also follow this convention?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where possible and where we stumble over it, yes. @thesamesam?

app-admin/kio-admin/kio-admin-9999.ebuild Outdated
KEYWORDS=""

DEPEND="
>=dev-qt/qtbase-${QTMIN}:6[dbus,gui,network,xml]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you establish Qt6Network and Qt6Xml all of a sudden?

Copy link
Contributor Author

@parona-source parona-source Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Included libraries that I saw kio-admin link against. With headers I only see explicit usage of dbus and widgets

ldd /usr/libexec/kf6/kio-admin-helper /usr/lib64/qt6/plugins/kf6/kio/admin.so /usr/lib64/qt6/plugins/kf6/kfileitemaction/kio-admin.so | grep libQt
        libQt6DBus.so.6 => /usr/lib64/libQt6DBus.so.6 (0x000070427508b000)
        libQt6Core.so.6 => /usr/lib64/libQt6Core.so.6 (0x0000704274800000)
        libQt6Network.so.6 => /usr/lib64/libQt6Network.so.6 (0x0000704273c00000)
        libQt6Xml.so.6 => /usr/lib64/libQt6Xml.so.6 (0x0000704274eb3000)
        libQt6Gui.so.6 => /usr/lib64/libQt6Gui.so.6 (0x0000704271e00000)
        libQt6DBus.so.6 => /usr/lib64/libQt6DBus.so.6 (0x0000795e76591000)
        libQt6Core.so.6 => /usr/lib64/libQt6Core.so.6 (0x0000795e75e00000)
        libQt6Network.so.6 => /usr/lib64/libQt6Network.so.6 (0x0000795e75200000)
        libQt6Xml.so.6 => /usr/lib64/libQt6Xml.so.6 (0x0000795e76498000)
        libQt6Gui.so.6 => /usr/lib64/libQt6Gui.so.6 (0x0000795e73200000)
        libQt6Gui.so.6 => /usr/lib64/libQt6Gui.so.6 (0x00007132cde00000)
        libQt6Core.so.6 => /usr/lib64/libQt6Core.so.6 (0x00007132cd600000)
        libQt6Network.so.6 => /usr/lib64/libQt6Network.so.6 (0x00007132cca00000)
        libQt6Widgets.so.6 => /usr/lib64/libQt6Widgets.so.6 (0x00007132cbc00000)
        libQt6DBus.so.6 => /usr/lib64/libQt6DBus.so.6 (0x00007132cd122000)
        libQt6Xml.so.6 => /usr/lib64/libQt6Xml.so.6 (0x00007132cd55e000)
        libQt6WaylandClient.so.6 => /usr/lib64/libQt6WaylandClient.so.6 (0x00007132ca6f3000)

Edit: Decided to use the headers as the final on what should be included as use flags.

Copy link
Member

@a17r a17r Aug 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ldd is giving you linkage of deps, only use lddtree for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now.

So QtGui is linked due to https://github.com/KDE/kio-admin/blob/a2eb7c0783326f8f02c70fad38ea0648d5054786/src/fileaction/fileaction.cpp#L4. I see usage of QWidget though as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Do you want to fix that upstream?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to be absolutely sure, you could always build qtbase without any USE flags and gradually add USE flags to the ebuild and to the installed qtbase package, each time you build kio-admin and it complains.

I have done this a few times. It helps to save binpackages as you'll likely end up recompiling quite a bunch of times otherwise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed. Do you want to fix that upstream?

https://invent.kde.org/system/kio-admin/-/merge_requests/20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a17r a17r a17r requested changes

@eli-schwartz eli-schwartz eli-schwartz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parona-source @a17r @eli-schwartz