Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-wireless/remotemouse: new package #247

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vitaly-zdanevich
Copy link
Contributor

No description provided.

@vitaly-zdanevich
Copy link
Contributor Author

@stkw0 please review.

This package is important - because when mouse dies - the smartphone can be used as a backup.

@stkw0
Copy link
Contributor

stkw0 commented Oct 14, 2024

I already left some comments last week...

@vitaly-zdanevich
Copy link
Contributor Author

Where?

@stkw0
Copy link
Contributor

stkw0 commented Oct 15, 2024

As a review. Github changed the interface, so maybe it's a bit more hidden. For me it was shown as a small square to the right in the diff tab.

@antecrescent
Copy link
Contributor

I already left some comments last week...

Maybe I'm missing something but it seems like your comments got lost somewhere.
image

@stkw0
Copy link
Contributor

stkw0 commented Oct 18, 2024

Weird, I still can see it. In any case, the only problematic thing was the use of a fake version number. If upstream didn't provide a version number, I think it would be more honest and correct to use a timestamp.
The other little thing was to add rename the SRC_URI to ${P}.zip

@vitaly-zdanevich
Copy link
Contributor Author

Done.

@stkw0
Copy link
Contributor

stkw0 commented Oct 18, 2024

Thanks. Could you add RESTRICT=mirror too? Given it's "all rights reserved" there is no explicit permission to redistribute distfiles.

@stkw0
Copy link
Contributor

stkw0 commented Oct 18, 2024

Also, why there is an executable file that is not a shell script under /etc? That's smells bad. Could that be located in /opt for example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants