general-concepts/ebuild-revisions: mention balancing examples against… #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… stable Explicitly say that even 'no revision bump' examples should be balanced against whether a stable ebuild is being modified, as we want to minimize any risk of regressions there. i.e. It might be that a change would not need a revbump for an ~arch-only ebuild, but if the ebuild is stable, the principle of being conservative ofr stable would mean a revbump is warranted. Signed-off-by: Sam James <[email protected]>
thesamesam
force-pushed
the
revisions-vs-stable
branch
from
8302739
to
b5a0e92
Compare
ulm
reviewed
Oct 15, 2024
There was a problem hiding this comment.
Good point, but having it as a separate paragraph after the examples feels wrong to me (i.e. all important general information should be before the examples).
The 1st item of the numbered list above already says in parentheses "in the case of packages marked stable, every non-trivial change is classified as such". Maybe this could be split off into a separate item instead, so that it would be more pronounced?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… stable
Explicitly say that even 'no revision bump' examples should be balanced against whether a stable ebuild is being modified, as we want to minimize any risk of regressions there.
i.e. It might be that a change would not need a revbump for an ~arch-only ebuild, but if the ebuild is stable, the principle of being conservative ofr stable would mean a revbump is warranted.