Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encourage use of Windows path GUI #538

Merged
merged 18 commits into from
Aug 31, 2022
Merged

Encourage use of Windows path GUI #538

merged 18 commits into from
Aug 31, 2022

Conversation

neworderofjamie
Copy link
Contributor

@neworderofjamie neworderofjamie commented Aug 30, 2022

Based on many users falling into this trap, I replaced suggestions to use setx with instructions to use the Windows environment editing GUI (which I at least prefer).

While I was at it, I also:

  • Removed suggestions to use binary wheels - they just don't work well enough at the moment
  • Suggestion to download master as a zip - either download a stable release or use git, don't download an unstable and more-difficult-to-update zip.

This stuff is also explained in the readmes but, as discussed in #537, these have to be updated separately so I will only do that when we're all happy with the changes.

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #538 (8fbc5db) into master (348a921) will not change coverage.
The diff coverage is n/a.

❗ Current head 8fbc5db differs from pull request most recent head 04e0176. Consider uploading reports for the commit 04e0176 to get more accurate results

@@           Coverage Diff           @@
##           master     #538   +/-   ##
=======================================
  Coverage   87.03%   87.03%           
=======================================
  Files          84       84           
  Lines       18099    18099           
=======================================
  Hits        15753    15753           
  Misses       2346     2346           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the two typos.

@@ -80,24 +77,23 @@ repository.
with each other. The latest C++ compiler need not necessarily be
compatible with the latest CUDA toolkit.

(vi) Set the `CUDA_PATH` variable if it is not already set by the
system, by putting
(vi) GeNN uses the `CUDA_PATH` environment version to determine which
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

environment variable

@@ -127,7 +114,7 @@ Building PyGeNN is a little involved so we recommend installing a prebuilt binar
\endcode

\subsection pygenn_source_windows Installing PyGeNN from source on Windows
- Ensure that you have at least Python 3.5 and Visual Studio 2015 installed (extensions for earlier versions of Python cannot be built using any versions of Visual Studio new enough to support C++11). If you are using Visual Studio 2019, you need at least Python 3.7.5. These instructions assume that the Anaconda platform was used to install Python, but it _should_ be possible to install PyGeNN using suitable versions of Python installed in different way (please let us know if you suceed in doing so!)
- Ensure that you have at least Python 3.5 and Visual Studio 2015 installed (extensions for earlier versions of Python cannot be built using any versions of Visual Studio new enough to compile GeNN). If you are using Visual Studio 2019, you need at least Python 3.7.5. These instructions assume that the Anaconda platform was used to install Python, but it _should_ be possible to install PyGeNN using suitable versions of Python installed in different way (please let us know if you succeed in doing so!)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installed in a different way

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't spot any other typos and as said previously overall agree with all changes. Hopefully there will be less users struggling with the windows install.

@neworderofjamie neworderofjamie merged commit 206b436 into master Aug 31, 2022
@neworderofjamie neworderofjamie deleted the windows_path_gui branch August 31, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants