Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gorule-0000013 not filtering out IEA annotations #2224

Open
pgaudet opened this issue Feb 8, 2024 · 1 comment
Open

gorule-0000013 not filtering out IEA annotations #2224

pgaudet opened this issue Feb 8, 2024 · 1 comment

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Feb 8, 2024

GORULE:0000013 states:

Experimental annotations
(1) failing the taxon constraints are reported in the error reports but unchanged; non-experimental annotations
(2) are filtered out of the pipeline products.

(1) EXP evidence codes: EXP, IDA, IEP, IGC, IGI, IMP, IPI, HDA, HEP, HGI, HMP, HTP.

(2) non EXP annotations: IBA, IKR, IRD, IC, ISA, ISM, ISO, ISS, NAS, RCA, TAS, IEA.

However we have IEA annotations to GO:0030313 cell envelope that has a taxon restriction only in bacteria that are passing, see
geneontology/go-annotation#1636

DEHA2C08096g
Gram-negative-bacterium-type cell wall

should be filtered.

@balhoff is this your code?

Thanks, Pascale

@kltm
Copy link
Member

kltm commented Feb 8, 2024

@pgaudet I'd note that @dustine32 also has a hand in the late taxon constraint filter stage.

@kltm kltm moved this to To spec out & prioritize in GORULES (low-hanging fruit) Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To spec out & prioritize
Development

No branches or pull requests

2 participants