Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check annotations to 'cell envelope' and children #1636

Open
pgaudet opened this issue Sep 26, 2017 · 18 comments
Open

Check annotations to 'cell envelope' and children #1636

pgaudet opened this issue Sep 26, 2017 · 18 comments
Assignees

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Sep 26, 2017

Hello,

Cell envelope applies to prokaryotes only. We noticed a few EXP annotations in eukaryotes:

@doughowe @hdrabkin (who can I ask for GeneDB?)
Can you please have a look?

UniProtKB A0A0R4IZH2 part_of GO:0045203 PMID:21773621 ECO:0000314 20110913 ZFIN goEvidence=IDA
UniProtKB A4IGB6 part_of GO:0045203 PMID:27563101 ECO:0000314 20161110 ZFIN goEvidence=IDA
UniProtKB B3DK48 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB F1QPL3 part_of GO:0045203 PMID:27784684 ECO:0000314 20170406 ZFIN goEvidence=IDA
UniProtKB F1RAX4 part_of GO:0045203 PMID:27563101 ECO:0000314 20161110 ZFIN goEvidence=IDA
UniProtKB F8W297 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB F8W4J6 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB P41251 part_of GO:0009279 PMID:10065630 ECO:0000314 20090803 MGI goEvidence=IDA
UniProtKB P51576 part_of GO:0031240 PMID:11570704 ECO:0000314 20080512 MGI part_of(EMAPA:18321),part_of(CL:0000192) goEvidence=IDA
UniProtKB Q1ECX5 part_of GO:0045203 PMID:27563101 ECO:0000314 20161110 ZFIN goEvidence=IDA
UniProtKB Q4V9K3 part_of GO:0045203 PMID:27784684 ECO:0000314 20170406 ZFIN goEvidence=IDA
UniProtKB Q563W7 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB Q6DGZ6 part_of GO:0045203 PMID:27563101 ECO:0000314 20161110 ZFIN goEvidence=IDA
UniProtKB Q7T3Q4 part_of GO:0045203 PMID:21773621 ECO:0000314 20110913 ZFIN goEvidence=IDA
UniProtKB Q8BVC1 part_of GO:0030112 PMID:18787081 ECO:0000314 20110323 MGI part_of(CL:0000019) goEvidence=IDA
UniProtKB Q8IBB9 part_of GO:0031244 PMID:19820120 ECO:0000314 20091019 GeneDB goEvidence=IDA
UniProtKB Q9PTQ8 part_of GO:0045203 PMID:27784684 ECO:0000314 20170406 ZFIN goEvidence=IDA
UniProtKB S5UFQ9 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA

Thanks, Pascale

@pgaudet pgaudet self-assigned this Sep 26, 2017
@doughowe
Copy link

Hi Pascale,
I think there might be an ontology problem here where the "cell envelope" term which is taxon restricted is the parent of terms which are not taxon restricted, like "integral component of cell outer membrane"?
screen shot 2017-09-26 at 9 57 38 am

@doughowe
Copy link

Maybe the part_of relationship between "cell envelope" and "cell outer membrane" is an error?

@doughowe
Copy link

Then again, maybe not. It looks like "plasma membrane" is the term eukaryotes should use rather than cell outer membrane?

@doughowe
Copy link

doughowe commented Sep 26, 2017

Hi @cerivs
The ZFIN annotations reported above are found in 4 pubs you curated. Could you take a look and move the GO annotations to terms suited for eukaryotes. Thanks! I've organized the ZFIN ones by pub here for convenience:

UniProtKB A4IGB6 part_of GO:0045203 PMID:27563101 ECO:0000314 20161110 ZFIN goEvidence=IDA
UniProtKB Q1ECX5 part_of GO:0045203 PMID:27563101 ECO:0000314 20161110 ZFIN goEvidence=IDA
UniProtKB F1RAX4 part_of GO:0045203 PMID:27563101 ECO:0000314 20161110 ZFIN goEvidence=IDA
UniProtKB Q6DGZ6 part_of GO:0045203 PMID:27563101 ECO:0000314 20161110 ZFIN goEvidence=IDA
UniProtKB B3DK48 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB F8W297 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB F8W4J6 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB Q563W7 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB S5UFQ9 part_of GO:0045203 PMID:27628598 ECO:0000314 20161121 ZFIN goEvidence=IDA
UniProtKB F1QPL3 part_of GO:0045203 PMID:27784684 ECO:0000314 20170406 ZFIN goEvidence=IDA
UniProtKB Q4V9K3 part_of GO:0045203 PMID:27784684 ECO:0000314 20170406 ZFIN goEvidence=IDA
UniProtKB Q9PTQ8 part_of GO:0045203 PMID:27784684 ECO:0000314 20170406 ZFIN goEvidence=IDA
UniProtKB Q7T3Q4 part_of GO:0045203 PMID:21773621 ECO:0000314 20110913 ZFIN goEvidence=IDA
UniProtKB A0A0R4IZH2 part_of GO:0045203 PMID:21773621 ECO:0000314 20110913 ZFIN goEvidence=IDA

ps...I think we need to look at our expression and phenotype annotations as well. I think there might be expression data related to this prokaryote only term...I'm not sure about phenotypes.

@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 26, 2017

Hi @doughowe

  • The outer membrane is limited to prokaryotes (and specifically gram negative). See wikipedia https://en.wikipedia.org/wiki/Cell_membrane#Prokaryotes
    "Gram-negative bacteria have both a plasma membrane and an outer membrane separated by periplasm. Other prokaryotes have only a plasma membrane. "

  • Taxon constraints are inherited: ie if an organelle/process/function does not exist in a species, its subparts/subtypes/subprocesses do not exist in that organism either. Does that seem logically correct to you ?

Thanks,
Pascale

@ukemi
Copy link
Contributor

ukemi commented Sep 26, 2017

I have changed two of the mouse annotations, but the third:

UniProtKB Q8BVC1 part_of GO:0030112 PMID:18787081 ECO:0000314 20110323 MGI part_of(CL:0000019) goEvidence=IDA

to glycocalyx, is valid based on the definition of the term and a quick search of the literature. We either need to change the parentage or create a separate class for things like sperm/epithelial glycocalyx and the ones found in fish, although the fish one might be considered an anatomical structure.

@ukemi
Copy link
Contributor

ukemi commented Sep 26, 2017

Or remove the taxon constriction of the cell envelope.

@pgaudet
Copy link
Contributor Author

pgaudet commented Sep 26, 2017

Hi @ukemi
Indeed we should change the parentage - the cell envelope really refers to the bacterial. Maybe GO:0071944 cell periphery?

Thanks, Pascale

@doughowe
Copy link

Still, editing the ontology will still leave the annotation pointed out by Pascale as needing to be cleaned up in mouse and zebrafish, right?

@ukemi
Copy link
Contributor

ukemi commented Sep 26, 2017

Not to glycocalyx. I think the mouse annotation is ok. I'm not sure about fish. I think moving to cell periphery will at least fix the issue for the glycocalyx that surrounds certain types of eukaryotic cells.

@doughowe
Copy link

doughowe commented Sep 26, 2017

@cerivs
I updated the ZFIN gene expression data for the bves gene and 3 antibodies which had expression in cell outer membrane. Updated those to plasma membrane.

@cerivs
Copy link

cerivs commented Sep 26, 2017

I fixed the Zebrafish annotations. It would be really helpful if the taxon limitation was propagated down tree since I had to go up a fair way until the in bacteria showed up. Perhaps prokaryotic could be added to the text definition of the branch for curator convenience.

@doughowe
Copy link

doughowe commented Oct 2, 2017 via email

@doughowe
Copy link

doughowe commented Oct 2, 2017 via email

@ValWood
Copy link
Contributor

ValWood commented Aug 29, 2023

The offending annotations have gone, but there are new ones, despite the taxon constraint:

Screenshot 2023-08-29 at 17 50 21

Not sure who to tag for these.

@ValWood
Copy link
Contributor

ValWood commented Aug 29, 2023

@pgaudet we could close since these are taxon restricted.
Should taxon restricted IEA even be loaded?

@suzialeksander
Copy link
Contributor

@uliboehme one of these is an IDA to GAMA, Plasmodium falciparum 3D7

@jlewsmith the others are CGD but are IEAs, can you just check that these aren't being generated or passed through anymore by CGD?

@pgaudet
Copy link
Contributor Author

pgaudet commented Feb 8, 2024

Should taxon restricted IEA even be loaded?

Technically they are filtered, but it looks like this is not applied here. I opened a ticket in the go-site repo:
geneontology/go-site#2224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants