-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output most specific taxon constraints for every term in go-computed-taxon-constraints.owl #28760
Comments
@balhoff Hi Jim, I can switch pipelines to use go-computed-taxon-constraints.obo file. Couple of question before I do this.
|
@alexsign I haven't merged the change yet, since I wanted to make sure you were ready. It will be around 20,000 terms after the change. You will either be able to get these from the import file, or else just continue using go-plus, since they will be merged in there. I can try to add never_in_taxon to ro_import. Not sure why it wouldn't be there already. However with the new computed taxon constraints you shouldn't need to use any property chains from RO anymore. |
@balhoff Thanks Jim, when data will be in go-plus, I can switch off my own propagation quite fast. Please go ahead with merge when you ready. |
Thanks @alexsign, I merged the PR, so the new data should be appearing soon. |
@balhoff precomputed taxon constraint now processed by GOA and available in the QuickGO |
That's great @alexsign! Looks good. I think you can change one thing; the taxon constraints table no longer needs to say "Ancestor GO ID | Ancestor GO Term Name", since these are directly on the term. |
@balhoff I'm not sure what changes to go-plus.json make all taxon constraint disappear from the GOA database. I'm looking into it now. What I found is following section is not in go-plus.json any more. |
@alexsign I did update the JSON output to use ROBOT instead of owltools (newer version of obographs JSON library). It seems like the only difference there is some changes to the text in the label and the definition, and removal of the empty xrefs list. Are you also having trouble with http://purl.obolibrary.org/obo/RO_0002162? |
@balhoff Small question: I was expecting to see RO:0002161 (never_in_taxon) in the GOlr |
@kltm I answered at geneontology/amigo#721 (comment). |
The current computed taxon constraints require navigation up the class hierarchy to get the full set of constraints applying to a term. In cases of multiple applicable constraints, some complex reasoning is still required in order to know which are the most specific constraints for a term. To simplify usage by consumers, we will compute the applicable taxon constraints for every GO term and directly assert them, so no traversal or reasoning is required.
@alexsign when this is incorporated, QuickGO can simply show the direct taxon constraints for each term rather than showing any from ancestor terms.
The text was updated successfully, but these errors were encountered: