Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add taxon constraints to display (redux) #721

Open
kltm opened this issue Sep 10, 2024 · 5 comments
Open

Add taxon constraints to display (redux) #721

kltm opened this issue Sep 10, 2024 · 5 comments

Comments

@kltm
Copy link
Member

kltm commented Sep 10, 2024

This was first attempted with #56 but, due to confusion in some cases, it was removed from view.

With the addition of pre-computed ontology terms with geneontology/go-ontology#28760, we'd like to re-add these to the display.

We'll do a cross-check with the issues found in #712 and make sure we're correct this time around.

@kltm
Copy link
Member Author

kltm commented Sep 20, 2024

GO:0007117

https://golr.geneontology.org/solr/select?defType=edismax&qt=standard&indent=on&wt=json&rows=10&start=0&fl=*,score&facet=true&facet.mincount=1&facet.sort=count&json.nl=arrarr&facet.limit=25&hl=true&hl.simple.pre=%3Cem%20class=%22hilite%22%3E&hl.snippets=1000&fq=document_category:%22ontology_class%22&q=id:%22GO:0007117%22

Noting:

{
  "nodes": [
    {
      "id": "NCBITaxon:131567",
      "lbl": "cellular organisms"
    },
    {
      "id": "GO:0007114",
      "lbl": "cell budding"
    },
    {
      "id": "GO:0007118",
      "lbl": "budding cell apical bud growth"
    },
    {
      "id": "GO:1990252",
      "lbl": "Syp1 complex"
    },
    {
      "id": "GO:0007119",
      "lbl": "budding cell isotropic bud growth"
    },
    {
      "id": "GO:0007117",
      "lbl": "budding cell bud growth"
    },
    {
      "id": "GO:0040007",
      "lbl": "growth"
    }
  ],
  "edges": [
    {
      "sub": "GO:0007118",
      "obj": "GO:0007117",
      "pred": "is_a"
    },
    {
      "sub": "GO:0007117",
      "obj": "NCBITaxon:131567",
      "pred": "RO:0002162"
    },
    {
      "sub": "GO:0007119",
      "obj": "GO:0007117",
      "pred": "is_a"
    },
    {
      "sub": "GO:1990252",
      "obj": "GO:0007117",
      "pred": "RO:0002216"
    },
    {
      "sub": "GO:0007117",
      "obj": "GO:0040007",
      "pred": "is_a"
    },
    {
      "sub": "GO:0007117",
      "obj": "GO:0007114",
      "pred": "BFO:0000050"
    }
  ],
  "meta": {
  }
}

GO:0000804

https://golr.geneontology.org/solr/select?defType=edismax&qt=standard&indent=on&wt=json&rows=10&start=0&fl=*,score&facet=true&facet.mincount=1&facet.sort=count&json.nl=arrarr&facet.limit=25&hl=true&hl.simple.pre=%3Cem%20class=%22hilite%22%3E&hl.snippets=1000&fq=document_category:%22ontology_class%22&q=id:%22GO:0000804%22

{
  "nodes": [
    {
      "id": "NCBITaxon:131567",
      "lbl": "cellular organisms"
    },
    {
      "id": "GO:0000804",
      "lbl": "W chromosome"
    },
    {
      "id": "GO:0000803",
      "lbl": "sex chromosome"
    }
  ],
  "edges": [
    {
      "sub": "GO:0000804",
      "obj": "GO:0000803",
      "pred": "is_a"
    },
    {
      "sub": "GO:0000804",
      "obj": "NCBITaxon:131567",
      "pred": "RO:0002162"
    }
  ],
  "meta": {
  }
}

never_in_taxon (RO:0002161) not showing up; compare to:
https://www.ebi.ac.uk/QuickGO/term/GO:0007117
https://www.ebi.ac.uk/QuickGO/term/GO:0000804

@balhoff
Copy link
Member

balhoff commented Sep 23, 2024

@kltm do we need this merged first for never_in_taxon to show up? #720

@kltm
Copy link
Member Author

kltm commented Sep 24, 2024

@balhoff My understanding is "no". I was under the (possibly erroneous) belief that the addition of the pre-computed ontology terms would have these appear in the usual "neighborhood" graph . Let's touch bases on this this week?

@balhoff
Copy link
Member

balhoff commented Sep 24, 2024

I don't think you will get the never_in_taxon without Chris's PR. The precomputed taxon constraints just adds more, in different places, of the same things we had before.

@kltm
Copy link
Member Author

kltm commented Sep 24, 2024

@balhoff Okay, that's the info I was looking for--thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In progress
Development

No branches or pull requests

2 participants