WIP - Ribbon branch 1 #518
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #515 |
|
@kltm This works fine for react, probably mostly because its a base-component. However, I'm having trouble including this: https://www.npmjs.com/package/@geneontology/ribbon I published stuff here: http://xenademo.berkeleybop.io/ribbon.js . but possibly the minification is a problem. However, even if we fix that, we'll have a lot of dependency issues. I saw that the npm package includes is somehow a perl module. Of course, maybe it is there and I need to use require it within a js package, but then I need to move all of the js into a separate file (which is probably a good idea). Thoughts / Best-practices here? |
|
Consensus. Use the perl script to include the npm, similar to npm, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #515