-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implements ConditionalGMPE class and applies it with model of Macedo et al. (2019) #9197
base: master
Are you sure you want to change the base?
Conversation
Thanks @g-weatherill and sorry for not posting earlier. This will be very important for the ShakeMap team, and we plan to use this as a template to contribute more conditional models to OQ in the coming months. |
Hi @g-weatherill and @mmpagani, I'm trying to work out how to call this class with the preferred method as indicated in @micheles's response to an issue we had in which the advice is to use the If I simply substitute in the MacedoEtAl2019SInter model into @micheles's example: import numpy as np
from openquake.hazardlib import valid
from openquake.hazardlib.contexts import simple_cmaker
gsim = valid.gsim('''[MacedoEtAl2019SInter]''')
n = 10
mags = np.linspace(5, 7, n)
cmaker = simple_cmaker([gsim], ['PGA'], mags=['%.2f' % mag for mag in mags])
ctx = cmaker.new_ctx(n)
ctx["mag"] = mags
ctx["vs30"] = np.linspace(200, 300, n)
ctx["rrup"] = np.linspace(1, 100, n)
mean, sigma, tau, phi = cmaker.get_mean_stds([ctx]) I get a sensible error since I haven't specified a conditioning data or model:
If I try to add the condition data to the ctx: ctx["SA(1.0)_MEAN"] = np.logspace(-1., 0.0, n) I get an error:
I can get around this by directly creating the ctx with Additionally, the ConditionalGMPE class takes a gsim = valid.gsim('''[MacedoEtAl2019SInter]
gmpe=[AbrahamsonEtAl2015SInter]''') But that results in an error:
Any guidance on how to resolve these issues would be great. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you list AbrahamsonEtAl2019 in the comments but in the in fact you use AbrahamsonEtAl2015? Is this a typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is a typo. Thanks for spotting it.
@g-weatherill @micheles, we have another conditional GMM that we would like to contribute but it inherits from the ConditionalGMPE that is created in this pull request. I haven't run into this issue before. Should our feature branch off of the |
@emthompson-usgs Thanks for looking into this. A couple of comments:
Yes, the ctx has to be created as a recarray. The function looks for the required fields within the dtype.names of the recarray.
The following seems to work for me using valid.gsim:
I'm not totally fluent in the TOML syntax, but it should be possible to pass arguments to the GMM being specified in the
|
We are being slow in replying here because Marco has been travelling around the world in the last two weeks, please have patience. |
@g-weatherill Thanks for the pointers. We now have a branch with the Macedo et al. 2021 model and it is getting close to being ready and fully tested. I am hopeful that this feature will be merged (and the incompatibility with master can be resolved) and we can then add the 2021 model shortly after. In the meantime, we can think about possible contingency plans. |
The pull request implements a new form of GMPE, which is a conditional ground motion model. This describes a family of ground motion models in which the predicted parameter is dependent not only on source, distance and site properties, but also on a different ground motion measure (e.g. PGA, SA(T)). This is applied here to the GMM of Macedo et al. (2019), but several other examples can be found in the literature (e.g. Abrahamson et al., 2016; Liu et al. 2022; Campbell et al., 2023; among others). Most conditional GMMs are for intensity measures such as duration, Arias Intensity or Cumulative Absolute Velocity, which include as predictors the more common peak motion or response spectral parameters such as PGA or SA(T).
A general template for a conditional GMPE is provided via the
ConditionalGMPE
class, which extends the standard GMPE class in two ways: 1) it requires specification of the intensity measures upon which the predicted parameter is conditioned (including the spectral period) and 2) it adds a functionget_conditioning_ground_motions
, which retrieves the ground motion values themselves.The implementation is designed to address two use cases:
The case in which the ground motion values (GMVs) that form the inputs to the
ConditionalGMPE
are known explicitly or calculated independently of OpenQuake. This is the "Shakemap" case and applies when the GMM is used directly from the library (rather than as part of an OpenQuake calculation). Here the known GMVs and their uncertainties can be input into the GMM by adding these as labelled vectors inside thectx
recarray alonside the source, path and distance properties, e.g.PGA_MEAN
,PGA_TOTAL_STDDEV
,SA(1.0)_MEAN
,SA(1.0)_TOTAL_STDDEV
etc.The case in which the ground motion values (GMVs) are not specified a priori and must instead be determined from a ground motion model. This case would allow the conditional GMM to be used in a probabilistic seismic hazard and risk calculation, for which no GMVs are known a priori. The extact manner in which the uncertainty in the conditioning ground motion is propagated through to the predicted ground motion may vary from model to model and is therefore left to be addressed in the implementation of the GMM in question. The Macedo et al. (2019) GMM here illustrates clearly how this should be done, however.
If the GMPE is not specified nor are the predictor GMVs provided in the
ctx
then an error will be raised.Tests are developed for both the
ConditionalGMM
class and theMacedoEtAl2019SInter/SSlab
classes. For the Macedo et al. (2019) model we have not yet been able to obtain an independent implementation of the model from the authors to generate the test tables. We did, however, verify the output ground motions against the figures provided in the original publication to a satisfactory level of agreement. Wetherefore apply the NotVerified warning. The Macedo et al. (2019) model is also regionalised, so this is included as a configurable parameter and as a set of aliases.Finally, the conditional GMM is demonstrated in a classical PSHA test case via the Macedo et al. (2019) GMM to produce curves for Arias intensity conditioned on PGA and SA(1.0 s).
Including here @emthompson-usgs and @cbworden for feedback regarding the Shakemap use case.