Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add CLI command idl to generate IDL from source crate #589

Merged
merged 15 commits into from
Oct 23, 2024
Merged

feat(cli): add CLI command idl to generate IDL from source crate #589

merged 15 commits into from
Oct 23, 2024

Conversation

vobradovich
Copy link
Member

@vobradovich vobradovich commented Oct 17, 2024 •
edited
Loading

Usages

  • with current dir
cargo sails idl
  • with manifest-path
cargo sails idl --manifest-path E:\git\sails-test\app\Cargo.toml

@vobradovich vobradovich self-assigned this Oct 17, 2024
@DennisInSky DennisInSky changed the base branch from master to vo/idl-gen-meta October 17, 2024 14:31
DennisInSky
DennisInSky reviewed Oct 18, 2024
View reviewed changes
Copy link
Member

@DennisInSky DennisInSky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some CI test would be nice:

  • we have one which generates a program
  • then you can use generated program for obtaining its idl
  • then maybe compare obtained idl with the one generated during program test

rs/cli/src/idlgen.rs Outdated Show resolved Hide resolved
rs/cli/src/idlgen.rs Show resolved Hide resolved
rs/cli/src/idlgen.rs Outdated Show resolved Hide resolved
rs/cli/src/idlgen.rs Outdated Show resolved Hide resolved
rs/cli/src/idlgen.rs Outdated Show resolved Hide resolved
rs/cli/src/idlgen.rs Show resolved Hide resolved
rs/cli/src/idlgen.rs Outdated Show resolved Hide resolved
rs/cli/src/idlgen.rs Outdated Show resolved Hide resolved
Base automatically changed from vo/idl-gen-meta to master October 21, 2024 11:26
@vobradovich vobradovich changed the title feat(cli): add CLI command idl-gen to generate IDL from source crate feat(cli): add CLI command idl to generate IDL from source crate Oct 22, 2024
DennisInSky
DennisInSky reviewed Oct 23, 2024
View reviewed changes
Cargo.toml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
rs/cli/src/idlgen.rs Outdated Show resolved Hide resolved
rs/cli/src/idlgen.rs Outdated Show resolved Hide resolved
@vobradovich vobradovich merged commit 418c351 into master Oct 23, 2024
5 checks passed
@vobradovich vobradovich deleted the vo/cli-idl-gen branch October 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DennisInSky DennisInSky DennisInSky approved these changes

Assignees

@vobradovich vobradovich

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vobradovich @DennisInSky