Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gclayburg #23 #33

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix gclayburg #23 #33

wants to merge 6 commits into from

Conversation

abitgeeky
Copy link

PR for user32000 fix for SOA serial bleed problem resulting in additional \t; 1 serial numbers being appended to the zone file.

@gclayburg
Copy link
Owner

boy, it has been a while since I've looked at this code. It might be a few days before I have time to review it. I assume this fix is working for you?

@cdjohnson
Copy link

boy, it has been a while since I've looked at this code. It might be a few days before I have time to review it. I assume this fix is working for you?

Yes, I had to fix a few bugs in the original commits.

I deployed this on my ds418play and then forced a bunch of DCHP updates and static updates to make sure the zone file didn't get clobbered. It's been running for a week now without any problem.

@jglathe
Copy link

jglathe commented Apr 29, 2021

Integrated it, too. It's running now n my ioSafe N2, so far no issues.

@jglathe
Copy link

jglathe commented Apr 30, 2021

Well, that cratered pretty quickly. The script is killing the static sections (SOA record) and the NS record and serial.
crater
Also, the static addresses are likewise not preserved. Seems like there is still some work to do.

@abitgeeky
Copy link
Author

I actually fixed this a month ago, but forgot to push it to github. Try again.

@jglathe
Copy link

jglathe commented Apr 30, 2021

Hey, thanks. I'll try it out tomorrow, just finished fixing up the zone files. Have to find a way to preserve the static entries, though. Never thought I would look into coding sript...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants