feature(scoped-parent): implemented scoped container that inherit a parent container's registrations (final implementation). #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainer as a parent when creating another one, pulling its records into the new one.
gbtb16
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The idea behind this PR is to continue what was implemented in the PR by @ruicraveiro:
What has changed from the original PR?
Added comments to
KiwiContainer.scopedsection including an explanation of what the parent is used for.Used Map literal
<K, V>{}to create_namedProviders, as indicated in the Dart documentation instead ofMap<K, V>().Implemented unit tests made by @ruicraveiro, and improved to make it more verbose.
Changed where
DartVaderwas toDarthVaderin tests to follow how it is correctly written in fiction. (funny change) 😄All 20 tests are passed correctly.
Issues
This solution will also solve the issue: