Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typedef): fixed Factory typedef to follow the rules regarding the syntax of generic functions in typedef. #104

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

gbtb16
Copy link
Owner

@gbtb16 gbtb16 commented Jan 15, 2024

Description

As stated in pub.dev, kiwi's score is affected by a typedef problem, which Dart describes as the misnaming of generic functions.

image

What has changed?

  • Fixed Factory typedef to match the new way of creating typedefs in Dart.

The new code:
image

  • All 21 tests are passed correctly.

@gbtb16 gbtb16 added the bug Something isn't working label Jan 15, 2024
@gbtb16 gbtb16 self-assigned this Jan 15, 2024
@gbtb16 gbtb16 merged commit 94e56e5 into master Jan 15, 2024
13 checks passed
@gbtb16 gbtb16 deleted the bugfix/factory-typedef branch January 15, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant