Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(scoped-parent): implemented scoped container that inherit a parent container's registrations (final implementation). #101

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

gbtb16
Copy link
Owner

@gbtb16 gbtb16 commented Jan 15, 2024

Description

The idea behind this PR is to continue what was implemented in the PR by @ruicraveiro:

What has changed from the original PR?

  • Added comments to KiwiContainer.scoped section including an explanation of what the parent is used for.

  • Used Map literal <K, V>{} to create _namedProviders, as indicated in the Dart documentation instead of Map<K, V>().

image
image

  • Implemented unit tests made by @ruicraveiro, and improved to make it more verbose.

  • Changed where DartVader was to DarthVader in tests to follow how it is correctly written in fiction. (funny change) 😄

  • All 20 tests are passed correctly.

…arent to reuse its providers in the new instance.
@gbtb16 gbtb16 added the feature New feature or request label Jan 15, 2024
@gbtb16 gbtb16 self-assigned this Jan 15, 2024
…parent" to reuse its providers in the new instance.
@gbtb16 gbtb16 merged commit 9e815c2 into master Jan 15, 2024
13 checks passed
@gbtb16 gbtb16 deleted the feature/kiwi-scoped-parents branch January 15, 2024 16:59
@gbtb16 gbtb16 changed the title feature(scoped-parent): implemented optional named parameter called parent to reuse its providers in the new instance. feature(scoped-parent): implemented scoped container that inherit a parent container's registrations (final implementation). Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant