broker/client: quiet more noisy logging #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't warn on a clean server-side close of a List RPC that doesn't ever return a response. This is expected for a resumed listing which doesn't change. Use an attached Route of a previously completed Read, if available, and more importantly: clear the last Response of the previous stream. We could enter a condition where this was never cleared (for example, on NOT_JOURNAL_BROKER) if the _following_ request went to the correct broker, stayed open for a while with no data, and was then closed server-side. This can cause mis-leading and false-positive logged warnings. Update RetryReader to account for attempt being incremented on the next loop iteration.
mdibaiee
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't warn on a clean server-side close of a List RPC that doesn't ever return a response. This is expected for a resumed listing which doesn't change.
Use an attached Route of a previously completed Read, if available, and more importantly: clear the last Response of the previous stream. We could enter a condition where this was never cleared (for example, on NOT_JOURNAL_BROKER) if the following request went to the correct broker, stayed open for a while with no data, and was then closed server-side. This can cause mis-leading and false-positive logged warnings.
Update RetryReader to account for attempt being incremented on the next loop iteration.
This change is