Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the maximum accepted gRPC message size configurable #398

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

jgraettinger
Copy link
Contributor

@jgraettinger jgraettinger commented Sep 6, 2024

For Gazette and consumers. Previously, the default (4MB) was used and could not be changed. Now it's configurable by flag and environment variable for brokers and consumers:

--broker.max-grpc-recv-size= Maximum size of gRPC messages accepted by this server, in bytes (default: 4194304) [$BROKER_MAX_GRPC_RECV_SIZE]


This change is Reviewable

For Gazette and consumers. Previously, the default (4MB) was used and
could not be changed. Now it's configurable by flag and environment
variable for brokers and consumers:

  --broker.max-grpc-recv-size=  Maximum size of gRPC messages accepted by this server, in bytes (default: 4194304) [$BROKER_MAX_GRPC_RECV_SIZE]
Copy link

@willdonnelly willdonnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgraettinger jgraettinger merged commit 8e0bd21 into master Sep 6, 2024
1 check failed
@jgraettinger jgraettinger deleted the johnny/cfg-recv-size branch September 6, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants