grpc-gateway: emit default (zero-value) fields

Some existing clients are not as nimble at distinguishing the explicit empty vs implicit empty cases.
gazette · Sep 24, 2024 · 73afb30 · 73afb30
1 parent 7392043
commit 73afb30
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/cmd/gazette/main.go b/cmd/gazette/main.go
@@ -120,7 +120,7 @@ func (cmdServe) Execute(args []string) error {
 	pb.RegisterJournalServer(srv.GRPCServer, pb.NewVerifiedJournalServer(service, verifier))
 
 	var mux *runtime.ServeMux = runtime.NewServeMux(
-		runtime.WithMarshalerOption(runtime.MIMEWildcard, new(gateway.JSONPb)),
+		runtime.WithMarshalerOption(runtime.MIMEWildcard, &gateway.JSONPb{EmitDefaults: true}),
 		runtime.WithProtoErrorHandler(runtime.DefaultHTTPProtoErrorHandler),
 	)
 	pb.RegisterJournalHandler(tasks.Context(), mux, srv.GRPCLoopback)

diff --git a/mainboilerplate/runconsumer/run_consumer.go b/mainboilerplate/runconsumer/run_consumer.go
@@ -199,7 +199,7 @@ func (sc Cmd) Execute(args []string) error {
 	pc.RegisterShardServer(srv.GRPCServer, pc.NewVerifiedShardServer(service, service.Verifier))
 
 	var mux *runtime.ServeMux = runtime.NewServeMux(
-		runtime.WithMarshalerOption(runtime.MIMEWildcard, new(gateway.JSONPb)),
+		runtime.WithMarshalerOption(runtime.MIMEWildcard, &gateway.JSONPb{EmitDefaults: true}),
 		runtime.WithProtoErrorHandler(runtime.DefaultHTTPProtoErrorHandler),
 	)
 	pc.RegisterShardHandler(tasks.Context(), mux, srv.GRPCLoopback)