Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdf 1.12: rename state subelements with _state suffix #1377

Closed
wants to merge 3 commits into from
Closed

sdf 1.12: rename state subelements with _state suffix #1377

wants to merge 3 commits into from

Commits on Mar 1, 2024

  1. Spec 1.12: add _state suffix to state subelements 

    Signed-off-by: Steve Peters <[email protected]>
    @scpeters
    scpeters committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    818b8f3 View commit details
    Browse the repository at this point in the history

  2. Rename state elements when converting to 1.12 

    Update some existing tests to verify conversion logic.

Signed-off-by: Steve Peters <[email protected]>
    @scpeters
    scpeters committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    dd2054f View commit details
    Browse the repository at this point in the history

  3. Add tests showing problems with conversion 

    The Converter currently only acts on the first child
element it finds; it doesn't act on all sibling elements.
I've added example SDFormat files and tests to illustrate
the issue.

Signed-off-by: Steve Peters <[email protected]>
    @scpeters
    scpeters committed Mar 1, 2024
    Configuration menu
    Copy the full SHA
    e9de659 View commit details
    Browse the repository at this point in the history