Merge 12 ➡️ 13 #478
Merged
Merge 12 ➡️ 13 #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Voldivh <[email protected]>
Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>
* Use on `push` only on stable branches to avoid duplicate runs * Update project automation Signed-off-by: Addisu Z. Taddese <[email protected]>
This reworks all of the gz-transport tests to use Subprocess from gz-utils. Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Carlos Agüero <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-transport8 ➡️ ign-transport11
Signed-off-by: Addisu Z. Taddese <[email protected]>
Merge ign-transport11 ➡️ gz-transport12
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-transport13 #478 +/- ##
==================================================
- Coverage 87.76% 87.69% -0.08%
==================================================
Files 59 59
Lines 5704 5704
==================================================
- Hits 5006 5002 -4
- Misses 698 702 +4 ☔ View full report in Codecov by Sentry. |
mjcarroll
approved these changes
Feb 6, 2024
caguero
commented
Feb 6, 2024
| std::string cmd = "bash -c \". " + scriptPath.string() + | ||
| "; _gz_topic_flags\""; | ||
| std::string scriptOutput = custom_exec_str(cmd); | ||
| // TEST(gzTest, TopicHelpVsCompletionFlags) |
There was a problem hiding this comment.
@mjcarroll , I think we need to restore these two tests, they were temporary commented by me but the intent was to port them.
scpeters
reviewed
Feb 11, 2024
| // // _gz_service_flags\"" | ||
| // std::string cmd = "bash -c \". " + scriptPath.string() + | ||
| // "; _gz_service_flags\""; | ||
| // std::string scriptOutput = custom_exec_str(cmd); |
There was a problem hiding this comment.
porting this will be a bit tricky, since the custom_exec_str method now prefixes all commands with gz
There was a problem hiding this comment.
I think we can just use the unwrapped gz::utils::Subprocess for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
gz-transport12togz-transport13Branch comparison: gz-transport13...gz-transport12
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)