Use subprocess rather than custom code #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
reviewed
Aug 14, 2023
mjcarroll
force-pushed
the
mjcarroll/use_subprocess
branch
from
c61c0a5
to
2d7b3a4
Compare
mjcarroll
changed the base branch from
gz-transport12
to
mjcarroll/test_cleanup
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/use_subprocess
branch
from
2d7b3a4
to
03088cd
Compare
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/use_subprocess
branch
from
0f4e5e3
to
87fd846
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## gz-transport12 #429 +/- ##
==================================================
- Coverage 87.29% 87.27% -0.02%
==================================================
Files 60 60
Lines 5211 5211
==================================================
- Hits 4549 4548 -1
- Misses 662 663 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
Signed-off-by: Michael Carroll <[email protected]>
ahcorde
requested changes
Nov 28, 2023
Signed-off-by: Michael Carroll <[email protected]>
mjcarroll
force-pushed
the
mjcarroll/use_subprocess
branch
from
313399f
to
1c3d4b8
Compare
ahcorde
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks all of the gz-transport tests to use
Subprocessfrom gz-utils.