Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve windows workflow #1052

Draft
wants to merge 23 commits into
base: gz-rendering9
Choose a base branch
from

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 4, 2024

🦟 Bug fix

Summary

#1049 introduced the Windows Github Action workflow. This PR makes some improvements to the workflow:

  • Use script to determine major version number
  • Add sscache

The hope is to also fix the issue from #1049 with the Ogre2 plugin not being loaded properly in tests as can be seen from error messages like the following:

17: (2024-08-31 04:51:07.821) [debug] Read GZ_ENGINE_TO_TEST=ogre2
17: (2024-08-31 04:51:07.822) [debug] Read GZ_ENGINE_BACKEND=gl3plus
17: (2024-08-31 04:51:07.822) [info] Loading plugin [gz-rendering-ogre2]
Error: 24-08-31 04:51:07.822) [error] Failed to load plugin [gz-rendering-ogre2] : couldn't find shared library.

Opening as a draft since it's still not able to load the Ogre2 plugin.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Sep 4, 2024
@traversaro
Copy link
Contributor

From what I understand, all the tests (even for Linux and macOS) only work if installed, as the GZ_RENDERING_PLUGIN_PATH in

gz-rendering/CMakeLists.txt

Lines 192 to 196 in a9af984

if(MSVC)
set(GZ_RENDERING_PLUGIN_PATH ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_BINDIR})
else()
set(GZ_RENDERING_PLUGIN_PATH ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR})
endif()
variable does not point to where the plugins are actually installed.

@traversaro
Copy link
Contributor

From what I understand, all the tests (even for Linux and macOS) only work if installed, as the GZ_RENDERING_PLUGIN_PATH in

gz-rendering/CMakeLists.txt

Lines 192 to 196 in a9af984

if(MSVC)
set(GZ_RENDERING_PLUGIN_PATH ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_BINDIR})
else()
set(GZ_RENDERING_PLUGIN_PATH ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR})
endif()

variable does not point to where the plugins are actually installed.

And indeed colcon also installs, my bad, so that should not be the problem.

@iche033 iche033 mentioned this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Inbox
Development

Successfully merging this pull request may close these issues.

2 participants