Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash completion script install path #469

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 9, 2024

🦟 Bug fix

Summary

Fix bash completion script installation path. Issue reported when building gz-msgs-vendor for rolling:

23:29:16 CMake Error at core/cmd/cmake_install.cmake:82 (file):
23:29:16   file cannot create directory:
23:29:16   /opt/ros/rolling/opt/gz_msgs_vendor/share/gz/gz2.completion.d.  Maybe need
23:29:16   administrative privileges.

updated install path to be consistent with other pacakges, e.g. see install path in gz-transport and sdformat

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from caguero as a code owner October 9, 2024 17:55
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Oct 9, 2024
@iche033 iche033 merged commit eaf96af into gz-msgs11 Oct 9, 2024
12 checks passed
@iche033 iche033 deleted the fix_completion_install branch October 9, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants