Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSVC "possible loss of data" warning #434

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Mar 19, 2024

🦟 Bug fix

Summary

The warning appears in gz-launch and it's due to the fact that we're assigning a uint64_t to an int32_t.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from caguero as a code owner March 19, 2024 16:12
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.19%. Comparing base (6ec4a1f) to head (2a328cc).

Additional details and impacted files
@@            Coverage Diff             @@
##           gz-msgs10     #434   +/-   ##
==========================================
  Coverage      98.19%   98.19%           
==========================================
  Files             27       27           
  Lines           1166     1166           
==========================================
  Hits            1145     1145           
  Misses            21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey merged commit 5f90910 into gazebosim:gz-msgs10 Mar 19, 2024
12 checks passed
@azeey azeey deleted the fix_msvc_warning branch March 19, 2024 16:44
azeey added a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants