Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include config.hh to get needed macros #426

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Part of gazebosim/gz-cmake#412.

Summary

This includes gz/msgs/config.hh wherever the GZ_MSGS_VERSION_NAMESPACE macro is used in order to provide the macro definition.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

This includes gz/msgs/config.hh wherever the
GZ_MSGS_VERSION_NAMESPACE macro is used in order
to provide the macro definition.

Part of gazebosim/gz-cmake#412.

Signed-off-by: Steve Peters <[email protected]>
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fbc0480) 97.41% compared to head (ea4d420) 97.41%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #426   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          27       27           
  Lines        1201     1201           
=======================================
  Hits         1170     1170           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit 2effe83 into main Feb 20, 2024
11 checks passed
@mjcarroll mjcarroll deleted the scpeters/version_namespace_macro branch February 20, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants