Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that tests pass fine with GZ_RELOCATABLE_INSTALL option enabled #394

Merged
merged 2 commits into from
Nov 7, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Oct 7, 2023

🦟 Bug fix

Fix tests when GZ_RELOCATABLE_INSTALL CMake option is enabled and the operating system is Windows or Linux without the install step being run.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Oct 7, 2023
@traversaro traversaro marked this pull request as draft October 7, 2023 14:54
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #394 (4a1a615) into gz-msgs10 (3d60486) will not change coverage.
The diff coverage is n/a.

❗ Current head 4a1a615 differs from pull request most recent head 448d107. Consider uploading reports for the commit 448d107 to get more accurate results

@@            Coverage Diff             @@
##           gz-msgs10     #394   +/-   ##
==========================================
  Coverage      97.67%   97.67%           
==========================================
  Files             27       27           
  Lines           1163     1163           
==========================================
  Hits            1136     1136           
  Misses            27       27           

@mjcarroll
Copy link
Contributor

Friendly ping @traversaro, if this is ready I can review.

@traversaro traversaro marked this pull request as ready for review November 7, 2023 10:31
@traversaro
Copy link
Contributor Author

Friendly ping @traversaro, if this is ready I can review.

Ok! For the DCO should I rebased on the latest gz-msgs10 dropping the merge and adding the DCO just on the latest rebased commit?

@mjcarroll
Copy link
Contributor

Ok! For the DCO should I rebased on the latest gz-msgs10 dropping the merge and adding the DCO just on the latest rebased commit?

Rebasing generally fixes it, but I can also override it as I have done here, since it's the merge commit causing the issue.

@mjcarroll mjcarroll merged commit 4f32cf4 into gazebosim:gz-msgs10 Nov 7, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants