Add rule-of-five members for Angle (#186)

Signed-off-by: Michael Carroll <[email protected]>
gazebosim · Jan 20, 2021 · bb60be4 · bb60be4
1 parent bd1173d
commit bb60be4
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 7 deletions.
diff --git a/include/ignition/math/Angle.hh b/include/ignition/math/Angle.hh
@@ -97,9 +97,21 @@ namespace ignition
  /// \param[in] _angle Angle to copy
  public: Angle(const Angle &_angle);
 
+ /// \brief Move constructor
+ /// \param[in] _angle Angle to move
+ public: Angle(Angle &&_angle) noexcept;
+
  /// \brief Destructor
  public: virtual ~Angle();
 
+ /// \brief Copy assignment operator
+ /// \param[in] _angle Angle to copy
+ public: Angle& operator=(const Angle &_angle);
+
+ /// \brief Move assignment operator
+ /// \param[in] _angle Angle to move
+ public: Angle& operator=(Angle &&_angle) noexcept;
+
  /// \brief Set the value from an angle in radians.
  /// \param[in] _radian Radian value.
  /// \sa SetRadian(double)

diff --git a/src/Angle.cc b/src/Angle.cc
@@ -37,15 +37,19 @@ Angle::Angle(const double _radian)
 }
 
 //////////////////////////////////////////////////
-Angle::Angle(const Angle &_angle)
-{
- this->value = _angle.value;
-}
+Angle::Angle(const Angle &_angle) = default;
 
 //////////////////////////////////////////////////
-Angle::~Angle()
-{
-}
+Angle::Angle(Angle &&_angle) noexcept = default;
+
+//////////////////////////////////////////////////
+Angle::~Angle() = default;
+
+//////////////////////////////////////////////////
+Angle &Angle::operator=(const Angle &_angle) = default;
+
+//////////////////////////////////////////////////
+Angle &Angle::operator=(Angle &&_angle) noexcept = default;
 
 //////////////////////////////////////////////////
 void Angle::Radian(double _radian)