Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix websocket proto request handling #281

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fix websocket proto request handling #281

merged 1 commit into from
Oct 11, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Oct 11, 2024

🦟 Bug fix

Depends on gazebosim/gz-msgs#470

Fixes #246

Summary

Added workaround to fix websocket proto message request. Duplicate message types should be removed in gazebosim/gz-msgs#470. In addition, nested messages also leads to duplicate messages so worked around it by leaving it out of the response.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Ian Chen <[email protected]>
VincidaB

This comment was marked as outdated.

@iche033
Copy link
Contributor Author

iche033 commented Oct 11, 2024

yes gzweb is missing support for shapes like like cone and ellipsoid, which are added in newer versions of gz

@VincidaB
Copy link

Made a PR there to add the support : gazebo-web/gzweb#62
gzweb seem to not have received support in a long time, is the project dead ?

@iche033
Copy link
Contributor Author

iche033 commented Oct 11, 2024

Thanks for the PR in gzweb. I think the gzweb team is focusing on something else. The project is still used by different groups of people. The devs are just not working on adding new features at the moment.

@iche033 iche033 merged commit c60538a into gz-launch8 Oct 11, 2024
10 of 11 checks passed
@iche033 iche033 deleted the websocket_msgs branch October 11, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

websocket server sends duplicate message headers in protos response
3 participants