Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3 ➡️ 5 #377

Merged
merged 7 commits into from
Mar 28, 2022
Merged

3 ➡️ 5 #377

merged 7 commits into from
Mar 28, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gui3 to ign-gui5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 7 commits March 3, 2022 11:06
@chapulina
Backport GridConfig improvements to Citadel's Grid3D (#363)
9fa41b6 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Improve KeyPublisher's usability (#362)
fc2f870 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Fix menu scrolling when a new plugin is added (#368)
755b995 
Signed-off-by: Louise Poubel <[email protected]>
@ahcorde @chapulina
Added Snackbar qtquick object (#369)
5428d26 
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@chapulina
Fix some Qt warnings (#376)
c14f379 
Signed-off-by: Louise Poubel <[email protected]>
@ahcorde @chapulina
Added array to snackbar qml (#370)
3cd66a8 
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@chapulina
3 -> 5
b3c07a5 
Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🏢 edifice Ignition Edifice label Mar 25, 2022
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #377 (f872712) into ign-gui5 (ee901c4) will decrease coverage by 1.77%.
The diff coverage is 10.75%.

❗ Current head f872712 differs from pull request most recent head b3c07a5. Consider uploading reports for the commit b3c07a5 to get more accurate results

@@             Coverage Diff              @@
##           ign-gui5     #377      +/-   ##
============================================
- Coverage     67.35%   65.58%   -1.78%     
============================================
  Files            29       30       +1     
  Lines          3388     3475      +87     
============================================
- Hits           2282     2279       -3     
- Misses         1106     1196      +90
Impacted Files Coverage Δ
include/ignition/gui/MainWindow.hh 100.00% <ø> (ø)
src/plugins/grid_3d/Grid3D.hh 100.00% <ø> (ø)
src/plugins/screenshot/Screenshot.cc 30.12% <0.00%> (-3.22%) ⬇️
src/plugins/grid_3d/Grid3D.cc 10.58% <6.33%> (-17.99%) ⬇️
src/plugins/teleop/Teleop.cc 83.19% <37.50%> (-1.77%) ⬇️
src/plugins/image_display/ImageDisplay.cc 30.95% <66.66%> (+0.87%) ⬆️
src/Application.cc 85.91% <100.00%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee901c4...b3c07a5. Read the comment docs.

@chapulina chapulina mentioned this pull request Mar 28, 2022
Closed
30 tasks
@chapulina chapulina requested a review from ahcorde March 28, 2022 18:12
@chapulina chapulina merged commit f0d1043 into ign-gui5 Mar 28, 2022
@chapulina chapulina deleted the chapulina/3_to_5 branch March 28, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @ahcorde