Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added results as output parameters #149

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Added results as output parameters #149

merged 1 commit into from
Mar 14, 2024

Conversation

@gaurav-nelson gaurav-nelson force-pushed the step-output branch 4 times, most recently from 08bccec to 71c4424 Compare August 9, 2022 08:25
@gaurav-nelson gaurav-nelson changed the title Added results as output parameters WIP: Added results as output parameters Aug 9, 2022
@edumserrano
Copy link

edumserrano commented Sep 4, 2022

@gaurav-nelson What's your thinking on this work?

I was thinking that perhaps we could implement this feature by adding an action input to decide whether to set the output from mlc as an action output or as a file. This could default to output only to console as it stands now.

The reason I'm suggesting this is because sometimes the output from mlc might exceed the maximum value for a step output. If the user finds himself in that situation he can switch to use a file output and still get a hold of the results on the next step of the workflow.

Or perhaps as a first version you just allow outputting to a file since that will always work. When comparing with outputting to a file, setting the mlc output as an action output is more for convenience than anything else.

Also, if you consider outputting to a file you can just have a default filepath but you can also allow the user to select the filepath as another action input parameter

@edumserrano
Copy link

Hi @gaurav-nelson, any thoughts on the above comment?

@edumserrano
Copy link

edumserrano commented Mar 8, 2023

Hi @gaurav-nelson,
In case you missed it, GitHub has updated the way the output is set. See GitHub Actions: Deprecating save-state and set-output commands.

The official docs have been updated as well: Setting an output parameter.

Furthermore, this change on GitHub means we don't have to worry anymore with encoding multi-line output values. So some things that you have in this branch that are like the below aren't needed anymore:

MLC_OUTPUT="${MLC_OUTPUT//'%'/'%25'}"
MLC_OUTPUT="${MLC_OUTPUT//$'\n'/'%0A'}"
MLC_OUTPUT="${MLC_OUTPUT//$'\r'/'%0D'}"

The change should be very straightforward from what you have to the new API. Hope this helps. Any thoughts on when we could have this merged?

@tyler36
Copy link

tyler36 commented Jun 27, 2023

Looking forward to this.

@moonbox3
Copy link

moonbox3 commented Mar 5, 2024

Hi @gaurav-nelson, are there any plans to get this merged in? We find your workflow very useful, and I'd love to see an output of the results (i.e. failures if any are detected), as oppose to having to sift through all of the results for the broken link. Thanks!

@gaurav-nelson
Copy link
Owner Author

Thank you everyone for chipping in. I'll try to get this in.

@gaurav-nelson gaurav-nelson changed the title WIP: Added results as output parameters Added results as output parameters Mar 14, 2024
@gaurav-nelson gaurav-nelson merged commit 25b2c43 into master Mar 14, 2024
3 checks passed
@gaurav-nelson
Copy link
Owner Author

Thank you all. You can use this using the SHA as described at https://github.com/gaurav-nelson/github-action-markdown-link-check?tab=readme-ov-file#versioning

- uses: gaurav-nelson/github-action-markdown-link-check@25b2c436c653f0d4500d3c2df86e5c14e71e44e1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants