This repository has been archived by the owner on Sep 11, 2022. It is now read-only.
Fixes to responsive widow size #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added some changes to the resizer function as once it assigned a fixed width, every attempt to grab the element's width size would remain the same from the loops. I had to also assign null to s.currentTop and call the scroller(); to bring the stickyElement back in view after resizing the widow. I hope someone can provide a more efficient solution though as I feel calling the scroller function over again is a bit heavy. Hope this helps someone.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was experiencing problems when resizing the window of my browser. The sticky element would always have the same width after resizing.
In order to fix this issue, I added some changes to the resizer function as once it assigned a fixed width to the stickyElement, every attempt to grab the element's width size would remain the same from the loops.
I had to also assign null to s.currentTop and call the scroller(); to bring the stickyElement back in view after resizing the widow. I hope someone can provide a more efficient solution though as I feel calling the scroller function over again is a bit heavy.
Hope this helps someone.
Issue Note: If you resize the window fast you can notice that the sticky element will be off position by a few pixels. Will post an update if I can find an issue to this problem.