Fix hashing for integer plists #5807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hulpke
approved these changes
Oct 1, 2024
|
Looks good to me too! I second @hulpke request for an explicit test case. Or is it the case that this is a 32 vs 64bit issue and hence hard to test in this manner? |
reiniscirpons
approved these changes
Oct 2, 2024
fingolfin
force-pushed
the
mh/fix-dict-hash
branch
from
2ec829b
to
b2a1455
Compare
|
Sorry, it took some time, but I finally found a way to modify the test case by Leonard to trigger the bug without needing to call functions from |
fingolfin
added
regression
fingolfin
force-pushed
the
mh/fix-dict-hash
branch
from
b2a1455
to
7aa9f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported by @lhsoicher.