Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildsys: unify the three 'gap' executable linker rules #5788

Merged
merged 1 commit into from
Sep 5, 2024
Merged

buildsys: unify the three 'gap' executable linker rules #5788

merged 1 commit into from
Sep 5, 2024

Conversation

fingolfin
Copy link
Member

  • use $< to reference the object file containing main
  • for the Windows rules, use $(SHLIB_EXT) instead of hardcoding .dll

@fingolfin
buildsys: unify the three 'gap' executable linker rules
ad89191 
- use $< to reference the object file containing `main`
- for the Windows rules, use $(SHLIB_EXT) instead of hardcoding .dll
@fingolfin fingolfin added topic: build system release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Sep 3, 2024
markuspf
markuspf approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@markuspf markuspf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (under caution that my contextual knowledge of the buldsystem is a bit rusty)

@fingolfin fingolfin merged commit 0cd14ac into gap-system:master Sep 5, 2024
29 of 30 checks passed
@fingolfin fingolfin deleted the mh/buildsys-unify-linker-rules branch September 5, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuspf markuspf markuspf approved these changes

@ChrisJefferson ChrisJefferson Awaiting requested review from ChrisJefferson

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @markuspf