-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Another method for minimum generating set for finite groups #5716
Open
pranav-joshi-iitgn
wants to merge
25
commits into
gap-system:master
Choose a base branch
from
pranav-joshi-iitgn:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
2b74d1d
Added a method to deal with non solvable groups
pranav-joshi-iitgn 3534ad7
Removed the Error log
pranav-joshi-iitgn 5d00602
Minor Changes
pranav-joshi-iitgn af0531f
Minor Changes
pranav-joshi-iitgn 9ee8e9a
Small Changes
pranav-joshi-iitgn 25ed7d8
Fixed an error
pranav-joshi-iitgn 99bd539
Small Changes
pranav-joshi-iitgn e4234d1
Changed location of function
pranav-joshi-iitgn d0259db
Changed location of code
pranav-joshi-iitgn 257e077
Small Change
pranav-joshi-iitgn db92d52
Removed `mingenset_km1_reps`
pranav-joshi-iitgn 47ab818
small changes
pranav-joshi-iitgn 5fb927b
Very small change
pranav-joshi-iitgn a826f27
Reintroduced the error log
pranav-joshi-iitgn 6193173
Reintroduced the error log
pranav-joshi-iitgn ee8c073
Fixed a mistake and added some tests
pranav-joshi-iitgn 0175fb0
small change
pranav-joshi-iitgn 19b88a3
Removed the check
pranav-joshi-iitgn b436972
Updated tests
pranav-joshi-iitgn afc2a9d
fixed linting error
pranav-joshi-iitgn 1d2677d
Mentioned the function in the documentation
pranav-joshi-iitgn d520f2b
Very small change
pranav-joshi-iitgn 848b2f9
Merge branch 'gap-system:master' into master
pranav-joshi-iitgn fd35ad2
Merge branch 'gap-system:master' into master
pranav-joshi-iitgn 5a399d6
Merge branch 'gap-system:master' into master
pranav-joshi-iitgn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
tst/testinstall/opers/MinimalGeneratingSetUsingChiefSeries.tst
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
gap> START_TEST("MinimalGeneratingSetUsingChiefSeries.tst"); | ||
gap> CrossVerifyMinimalGeneratingSetUsingChiefSeries := function(startsize,endsize) | ||
> local G,size,gens1,gens2,G1,G2,i; | ||
> for size in [startsize..endsize] do | ||
> i := 0; | ||
> for G in AllSmallGroups(size) do | ||
> i := i + 1; | ||
> gens1:= MinimalGeneratingSet(G); | ||
> gens2:= MinimalGeneratingSetUsingChiefSeries(G); | ||
> if Length(gens1) = 0 then | ||
> if IsTrivial(G) then | ||
> if Length(gens2) > 0 then | ||
> return Concatenation("FAILED on AllSmallGroups(",String(size),")[",String(i),"]"); | ||
> else | ||
> continue; | ||
> fi; | ||
> else | ||
> return Concatenation("MinimalGeneratingSet is failing on AllSmallGroups(",String(size),")[",String(i),"]"); | ||
> fi; | ||
> fi; | ||
> G1 := GroupByGenerators(gens1); | ||
> if not G = G1 then | ||
> return Concatenation("MinimalGeneratingSet is failing on AllSmallGroups(",String(size),")[",String(i),"]"); | ||
> fi; | ||
> G2 := GroupByGenerators(gens2); | ||
> if (not G = G2) or Length(gens1) < Length(gens2) then | ||
> return Concatenation("FAILED on AllSmallGroups(",String(size),")[",String(i),"]"); | ||
> fi; | ||
> od; | ||
> od; | ||
> return "PASSED"; | ||
> end; | ||
function( startsize, endsize ) ... end | ||
gap> CrossVerifyMinimalGeneratingSetUsingChiefSeries(1,60); | ||
"PASSED" | ||
gap> CrossVerifyMinimalGeneratingSetUsingChiefSeries(115,125); | ||
"PASSED" | ||
gap> G := AlternatingGroup(5); | ||
Alt( [ 1 .. 5 ] ) | ||
gap> G := DirectProduct(G,G);; | ||
gap> mu := MinimalGeneratingSetUsingChiefSeries(G);; | ||
gap> G = GroupByGenerators(mu); | ||
true | ||
gap> Length(mu); | ||
2 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be
Length(gens1) != Length(gens2)
? If these are a different length, one of the functions is wrong?