Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/3.4 #157

Open
wants to merge 3 commits into
base: release/3.4
Choose a base branch
from
Open

Release/3.4 #157

wants to merge 3 commits into from

Conversation

gourhand
Copy link

See commit commentaries of the two files

"read() buffer overflow on file /proc/stat"

At the very first read :
- the file is read in a buffer sized with 4096 bytes
- if 4096 is not enough then the buffer i reallocated until the size is sufficient.
- then the right size is memorized in buffersize
Then all other are read with buffersize size with no possible re-allocation.

This behaviour is an issue with files like /proc/stat which can grow with time leading to infinite "read() buffer overflow on file .."

The purpose of the modification is to let the reallocation always possible
Modification done with  ../lib/file.c

"read() buffer overflow on file /proc/stat"

At the very first read :
- the file is read in a buffer sized with 4096 bytes
- if 4096 is not enough then the buffer i reallocated until the size is sufficient.
- then the right size is memorized in buffersize
Then all other are read with buffersize size with no possible re-allocation.

This behaviour is an issue with files like /proc/stat which can grow with time leading to infinite "read() buffer overflow on file .."

The purpose of the modification is to let the reallocation always possible
 Wrong RRD files rights
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant