This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
Fix prod and dev container after recent updates to pyproject.toml #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent updates to pyproject.toml unfortunately broke both dev and prod containers:
Prod:
The setting of the simtools version using setuptools-scm requires a full git clone (and not a simple wget of the zip file from github).
This requires also the installation of git which increase the size of the container by a very small amount.
Dev:
pip install '.[tests,dev,doc]'
is not working anymore without the simtools code available. I see three options to solve this and I've decided the last one is the simplest:pip install -r requirements.txt
.